Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace custom lazy loading with lazy_loader package #688

Merged
merged 3 commits into from
Oct 1, 2024

Conversation

hakonanes
Copy link
Member

Description of the change

  • Replace custom lazy loading of modules with the lazy_loader package: https://scientific-python.org/specs/spec-0001/#lazy_loader. This should reduce import times.
  • Use absolute internal imports everywhere but the stub files __init__.pyi
  • Move checks for whether optional dependencies are installed to a private kikuchipy.constants module
  • Create a private logging module (everything not listed in API reference in docs is private)

Progress of the PR

For reviewers

  • The PR title is short, concise, and will make sense 1 year later.
  • New functions are imported in corresponding __init__.py.
  • New features, API changes, and deprecations are mentioned in the unreleased
    section in CHANGELOG.rst.
  • New contributors are added to kikuchipy/__init__.py and .zenodo.json.

@hakonanes hakonanes added the maintenance This relates to package maintenance label Sep 30, 2024
@hakonanes hakonanes merged commit d5db481 into pyxem:develop Oct 1, 2024
11 checks passed
@hakonanes hakonanes deleted the use-lazy-loader branch October 1, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance This relates to package maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant