Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reading of Oxford Instrument's *.ebsp files with format version 6 #700

Merged
merged 10 commits into from
Nov 20, 2024

Conversation

hakonanes
Copy link
Member

@hakonanes hakonanes commented Nov 19, 2024

Description of the change

This PR fixes #690.

And #701.

Progress of the PR

Minimal example of the bug fix or new feature

The map (x, y) integer positions are new files with format version 6

>>> import kikuchipy as kp
>>> s = kp.load("file.ebsp")
>>> s.original_metadata
├── beam_x = array([-28.11170417, -26.11170417, -24.11170417, -22.11170417,
       -20.1117 ...    1.88829583,
         3.88829583,   5.88829583,   7.88829583,   9.88829583])
├── beam_y = array([34.11170417, 34.11170417, 34.11170417, 34.11170417, 34.11170417,
       ... 9583,
       -3.88829583, -3.88829583, -3.88829583, -3.88829583, -3.88829583])
├── file_order = array([  1,   0,   2,   4,   3,   6,   9,   5,   7,   8,  13,  10,  11,
       ...  386, 387, 388, 389,
       391, 390, 392, 393, 396, 394, 395, 397, 398, 399])
├── map1d_id = array([  0,   1,   2,   3,   4,   5,   6,   7,   8,   9,  10,  11,  12,
       ...  386, 387, 388, 389,
       390, 391, 392, 393, 394, 395, 396, 397, 398, 399])
├── map_x = array([ 0,  1,  2,  3,  4,  5,  6,  7,  8,  9, 10, 11, 12, 13, 14, 15, 16,
    ... ,  6,  7,  8,  9, 10,
       11, 12, 13, 14, 15, 16, 17, 18, 19], dtype=int32)
└── map_y = array([ 0,  0,  0,  0,  0,  0,  0,  0,  0,  0,  0,  0,  0,  0,  0,  0,  0,
    ... , 19, 19, 19, 19, 19,
       19, 19, 19, 19, 19, 19, 19, 19, 19], dtype=int32)

For reviewers

  • The PR title is short, concise, and will make sense 1 year later.
  • New functions are imported in corresponding __init__.py.
  • New features, API changes, and deprecations are mentioned in the unreleased
    section in CHANGELOG.rst.
  • New contributors are added to kikuchipy/__init__.py and .zenodo.json.

@hakonanes hakonanes added the bug Something isn't working label Nov 19, 2024
@hakonanes hakonanes added this to the v0.11.1 milestone Nov 19, 2024
@hakonanes hakonanes linked an issue Nov 19, 2024 that may be closed by this pull request
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@hakonanes hakonanes merged commit b17755b into pyxem:main Nov 20, 2024
10 of 11 checks passed
@hakonanes hakonanes deleted the 690-oxford-ebsp-aztec-6.1 branch November 20, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Oxford uncompressed .ebsp file load problem in Aztec V6.1
1 participant