Basic skeleton with tests #1
Conversation
| */ | ||
| public function loginFail() | ||
| { | ||
| $this->page = $this->page->loginFailure(); |
There was a problem hiding this comment.
That's incorrect approach.
Page provides method to interact with elements on a page. It doesn't have methods, that would deliberately fill the form with data, that will lead to failure/success to allow tests to use them.
There was a problem hiding this comment.
In that case always combine submit and filling the form? I always divided that but it could also be one step after all.
There was a problem hiding this comment.
The method on PageObject/element class represents complete action from UI/user viewpoint. User sees login process as single action: fill fields + press ENTER/login button. This way the PageObject should do it in same fashion.
|
Today’s review completed. |
| Behat\MinkExtension: | ||
| default_session: selenium2 | ||
| javascript_session: selenium2 | ||
| base_url: 'http://behat-example.qa-tools.io' |
There was a problem hiding this comment.
Maybe we should use http://localhost as url here and in other setting. It's most unlikely that people will have that domain.
Also in README.md I recommend mentioning steps required to make example operational, like go and replace base_url in 2 places with your actual url.
…ies and added steps for setup to README.md
evangelion1204
force-pushed
the
add-basic-example
branch
from
755bb93
to
a27f0c9
Compare
|
I updated the example a bit. |
| { | ||
|
|
||
| /** | ||
| * @Given I'm on ':page' |
There was a problem hiding this comment.
According to http://docs.behat.org/en/latest/guides/2.definitions.html the single or double quotes are not required around parameter names. Parameters would be detected in scenario even if somebody adds quotes by accident:
I'm on My Page
I'm on "My Page"
I'm on 'My Page'
Not sure how spaces are handled through.
There was a problem hiding this comment.
I didn't check that yet, but good to know, then I will drop them.
A basic skeleton which can be extended in the future.
Currently containing: