Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys, thanks for your project.
Full hashing was taking a lot of time on my HDD, and task manager reported read speed was kinda low, ~25MB/s so I suspected the small buffer might cause it.
Tested with 16MB buffer read speed increased to ~150MB/s which is what I would expect.
20 gb of duplicates is scanned in 3 minutes vs 13 on current release (without cache).
Interestingly if I run the same test on an NVMe then there's almost no difference: 17s vs 18s, ~2.4GB/s read speed.
I guess windows is reading small blocks from the drive without doing a lot of readahead. Increasing the buffer is kind of a simple fix.