Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding twitter users and misc #68

Closed
wants to merge 1 commit into from
Closed

Adding twitter users and misc #68

wants to merge 1 commit into from

Conversation

security-prince
Copy link

Adding James Kettle and resource for application security

Adding James Kettle and resource for application security
@qazbnm456
Copy link
Owner

Hi @security-prince, sorry to keep you waiting so long. Would you mind updating other README files at once? Thanks!

@security-prince
Copy link
Author

Hi @qazbnm456 I created 3 PRs, i am not sure what you meant by updating other README files at once. Closing this one, please check #79 #80 and #81

@qazbnm456
Copy link
Owner

Oh, I mean you can just add the same entry to 3 README files in one commit so as to get those files aligned. Not to create 3 separate PRs.

@security-prince
Copy link
Author

Oh, I mean you can just add the same entry to 3 README files in one commit so as to get those files aligned. Not to create 3 separate PRs.

I wasn't able to do that, as soon as you make a change in 1 file it asks to propose the changes which then creates a PR, am I missing something here?

@qazbnm456
Copy link
Owner

You can just edit 3 files in your fork and propose a sole PR containing your changes. No need to create 3 PRs.

@security-prince
Copy link
Author

okay, let me try doing that and then close these 3 PRs

@security-prince
Copy link
Author

Closing this, refer #83

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants