Add better multiple hospital support + some refactors

[BackSH00TER]

Describe Pull request
The main purpose of this PR is to tweak the existing implementations to make it easier to add support for multiple hospitals and clean up the logic surrounding this. It also cleans up a lot of the logic with regards to finding a free bed at the hospital.

• Updates Config.Locations to add each hospital location and its corresponding bed locations
• Combines GetAvailableBed and SetClosestBed with a newer function getClosestAvailableBed that takes the index of the hospital you are at to reduce the number of loops that are needed.
• Uses hospitalIndex to select the correct bed at that hospital location
• Updated areas that were previously looking at Config.Locations.beds to now look at Config.Locations.hospital[hospitalIndex].beds
• Updated some strings to use the correct hospital name

Tested:

• Hold E to respawn will still respawn you at Pillbox
• Checkin at hospitals will put you in the first open bed at that hospital
• Tested getting on hospital bed by walking up to and using the nearby functions to sit on bed
• Tested that beds isTaken status correctly resets when you leave the bed

Example showing checkin + sit on bed
https://clipchamp.com/watch/DL7ruUxMQpD

[nzkfc]

@BackSH00TER Could you please add it so it will check which hospital you're closest too and spawn you there instead of pillbox?

Also I noticed when you set checkin locations, you have to also ensure the "Location" for each hospital is the same vector? otherwise it won't let you checkin?

[github-actions]

This PR has had 60 days of inactivity & will close within 7 days

[github-actions]

This PR has had 60 days of inactivity & will close within 7 days

[BackSH00TER]

Commenting to remove staleness. Can someone from QB team comment whether or not this is something you would want to merge in? If yes, I'll update and fix the merge conflicts, if no, then lets just close this out

[Twikii]

Commenting to remove staleness. Can someone from QB team comment whether or not this is something you would want to merge in? If yes, I'll update and fix the merge conflicts, if no, then lets just close this out

I have try it on my server, its working smoothly, thanks bro!

[Irishstevie]

I can say this is something that would be awesome to see

[TheBlokker]

Perfect i dont see any problem

[BackSH00TER]

Commenting to remove staleness. Can someone from QB team comment whether or not this is something you would want to merge in? If yes, I'll update and fix the merge conflicts, if no, then lets just close this out

@GhzGarage I would appreciate if you could take a look at this if you have a chance. I'm more than happy to update and fix the merge conflicts if this is something you would actually want merged.

[nzkfc]

I'd say do the updates anyways man, did you add the hospital distance checking too determine where too spawn?

…

On Mon, 22 Jan 2024, 6:50 pm BackSH00TER, ***@***.***> wrote: Commenting to remove staleness. Can someone from QB team comment whether or not this is something you would want to merge in? If yes, I'll update and fix the merge conflicts, if no, then lets just close this out @GhzGarage <https://github.com/GhzGarage> I would appreciate if you could take a look at this if you have a chance. I'm more than happy to update and fix the merge conflicts if this is something you would actually want merged. — Reply to this email directly, view it on GitHub <#299 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABGHUHNO23BATD7WZ7UP7YTYPX43VAVCNFSM6AAAAAAYOJWEHCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBTGMYDOMRQHA> . You are receiving this because you commented.Message ID: ***@***.***>

[TheBlokker]

I checked it again, and not error, I see no problem in the code.

Is a error in testing?

[BackSH00TER]

I'd say do the updates anyways man, did you add the hospital distance checking too determine where too spawn?

I'm not going to waste my time continually updating and fixing merge conflicts just for the PR to sit unacknowledged for another 7+ months.

If I get the green light from somebody who is actually on the QB team and has merge permissions, then I will be more than happy to update it.

[nzkfc]

Welcome to qbcore lol

…

On Tue, 23 Jan 2024, 4:32 pm BackSH00TER, ***@***.***> wrote: I'd say do the updates anyways man, did you add the hospital distance checking too determine where too spawn? I'm not going to waste my time continually updating and fixing merge conflicts just for the PR to sit unacknowledged for another 7+ months. If I get the green light from somebody who is actually on the QB team and has merge permissions, then I will be more than happy to update it. — Reply to this email directly, view it on GitHub <#299 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABGHUHPAGTH5YSZ3NFJLASTYP4VOVAVCNFSM6AAAAAAYOJWEHCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBVGIZTGNZUGE> . You are receiving this because you commented.Message ID: ***@***.***>

[c-drive]

+1
This commit should really be added to master, it fixes a litany of issues present in the current code.

[jaylac2000]

PLZ Merge !!

[SinisterDevelopment]

i have pushed this to be merged!

[TheBlokker]

ready to be merged

[GhzGarage]

@SinisterDevelopment See if you can make a new PR on this without conflicts

[jaylac2000]

@GhzGarage

i might have a copy of it without conflicts. just gotta delete my m-Insurance integration and reset config if you want it

[BackSH00TER]

@SinisterDevelopment See if you can make a new PR on this without conflicts

@GhzGarage I can update this tonight

[BackSH00TER]

Merge conflicts are fixed. This is ready to go again

[BackSH00TER]

@GhzGarage @SinisterDevelopment this PR is ready to go. Please approve so this PR can be merged. Thank you.