fix shared update #988
Merged
fix shared update #988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's a temporary fix while we see how to do it better. but this in principle fixes the error that when a client entered it did not get the table of items etc updated. since shared_scripts does not serve to update information on both sides (client, server) it would fix problems with addItems, addItem, etc. It is not the best solution. but it's a temporary fix
|
Great work |
|
Also, why don't just push the whole QBshared table to client? |
The idea is good, but I think we should review it in more detail, as it could be an excessive burden. We should consider more efficient alternatives. |
I've changed the system and made it receive the information upon connection. I believe it works better than the previous one, at least in the tests I've conducted, and it fixes all the problems with job updates, vehicles, etc. |
|
I think you forgot to add "src" when using TriggerClientEvent. |
GhzGarage
reviewed
Sep 29, 2023
GhzGarage
added
enhancement
This was
linked to
issues
Sep 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a temporary fix while we see how to do it better. but this in principle fixes the error that when a client entered it did not get the table of items etc updated. since shared_scripts does not serve to update information on both sides (client, server) it would fix problems with addItems, addItem, etc.
It is not the best solution. but it's a temporary fix
Description
Checklist