Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotbar Live Refresh #451

Closed
wants to merge 2 commits into from
Closed

Hotbar Live Refresh #451

wants to merge 2 commits into from

Conversation

MrBerkk
Copy link

@MrBerkk MrBerkk commented Jul 17, 2023 •
edited
Loading

Description

video prewiev : https://streamable.com/q2m0g6

Checklist

  • I have personally loaded this code into an updated qbcore project and checked all of its functionality.
  • My code fits the style guidelines.
  • My PR fits the contribution guidelines.

i-kulgu
i-kulgu suggested changes Sep 29, 2023
View reviewed changes
Copy link

@i-kulgu i-kulgu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why updating the hotbar each second in a while true loop ?
Why not just trigger it from useitem event or something which would be way more optimized and only updated when needed ?

@github-actions GitHub Actions
Copy link

This PR has had 60 days of inactivity & will close within 7 days

@github-actions github-actions bot added the Stale label Nov 28, 2023
@github-actions github-actions bot closed this Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@i-kulgu i-kulgu i-kulgu requested changes

Assignees

@MrBerkk MrBerkk

Labels
Stale Closed Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MrBerkk @i-kulgu @GhzGarage