Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove archived affiliation from persons that related to these #939

Open
wants to merge 1 commit into
base: development
Choose a base branch
from
Open

Remove archived affiliation from persons that related to these #939

wants to merge 1 commit into from

Conversation

sven1103
Copy link
Contributor

No description provided.

@sven1103 sven1103 requested a review from a team as a code owner April 25, 2022 12:15
@github-actions github-actions bot added the fix label Apr 25, 2022
KochTobi
KochTobi requested changes Apr 25, 2022
View reviewed changes
Copy link
Member

@KochTobi KochTobi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good but introduces some erroneous behaviour.
Try the following:

  1. Create an offer with a project manager with only one affiliation
  2. Delete the affiliation of the project manager
  3. reload the page
  4. download the offer
  5. an exception is thrown/ the application is unresponsive

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KochTobi KochTobi KochTobi requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sven1103 @KochTobi