Change behavior when tray icon is clicked

[thalieht]

qBittorrent will be hidden only when it is in focus.

Closes #11424

[glassez]

The question is shouldn't we change behavior only for icon click and preserve the current one for context menu?

[thalieht]

The question is shouldn't we change behavior only for icon click and preserve the current one for context menu?

Done.

[glassez]

I believe you shouldn't do setWindowState((windowState() & ~Qt::WindowMinimized) | Qt::WindowActive); manually. The next 3 methods will care about it. Or did your tests show the another result?
And if I'm right, then it can even be rewritten as the following:

Suggested change

	if (isActiveWindow())
	{
	hide();
	}
	else
	{
	if (m_uiLocked && !unlockUI()) // Ask for UI lock password
	return;
	// Make sure the window is not minimized
	setWindowState((windowState() & ~Qt::WindowMinimized) | Qt::WindowActive);
	// Then show it
	show();
	raise();
	activateWindow();
	}
	if (isActiveWindow())
	hide();
	else
	activate();

[thalieht]

I didn't notice any problems at all.

I believe you shouldn't do setWindowState((windowState() & ~Qt::WindowMinimized) | Qt::WindowActive); manually.

Removing only that line or with your suggestion, when qBt is minimized (not to tray) clicking the tray icon doesn't restore the window.

[glassez]

Removing only that line or with your suggestion, when qBt is minimized (not to tray) clicking the tray icon doesn't restore the window.

OK.
Seems setWindowState(windowState() & ~Qt::WindowMinimized) is really required but setting Qt::WindowActive flag does exactly the same as activateWindow() so one of them can be omitted.

Unfortunately, this code does not work correctly (at least on Windows, where I managed to test it). It does not hide the main window when clicking on the tray icon. For some reason, isActiveWindow() always returns false.

[thalieht]

but setting Qt::WindowActive flag does exactly the same as activateWindow() so one of them can be omitted.

Ok i see no problems with removing Qt::WindowActive but i do with removing activateWindow():

1. qBt out of focus
2. Click tray icon and it brings qBt to the front
3. Subsequent tray icon clicks do nothing (qBt is not in focus)

Unfortunately, this code does not work correctly (at least on Windows, where I managed to test it). It does not hide the main window when clicking on the tray icon. For some reason, isActiveWindow() always returns false.

Damn... i can't test in Windows, i mean i could with CI builds but it would be a chore.

[glassez]

Ok i see no problems with removing Qt::WindowActive but i do with removing activateWindow()

In fact, the order of operations matters. show() has to go before activateWindow(), otherwise it doesn't work.

[glassez]

For some reason, isActiveWindow() always returns false.

It looks like main window becomes inactive at the moment when the user interacts with the tray icon.

[glassez]

In fact, I was always annoyed by the behavior of the qBittorrent tray icon, but it was a small thing for me, so I never even tried to delve into what exactly it does.
Now I tried to evaluate this problem.
I was always confused by the fact that when I clicked on the qBittorrent tray icon in the hope of seeing its window in front of my eyes, I eventually noticed that its window was previously open, but it was behind other windows or minimized to the taskbar, and at the moment of my click it simply hided into the tray, so I had to click again to see it.
Now I have checked the behavior when clicking on the icons of other applications that are constantly staying in my tray. And I found only three options:

1. no reaction, the window can only be opened from the context menu, (inconvenient),
2. duplicate the right click, i.e. the context menu is shown (unusual, but usable, its advantage is that you can avoid showing the window by accident),
3. shows the application window or brings a previously opened window to the foreground.

Note that none of the icons (except qBittorrent) hides the opened window when clicked. This can only be done either through the context menu of the icon, or by closing the window itself in the usual way.

[thalieht]

3. shows the application window or brings a previously opened window to the foreground.

Isn't that what we want?
Anyway i'll say it again that i can't do anything about Windows (should i close the PR?).

Note that none of the icons (except qBittorrent) hides the opened window when clicked.

Mumble behaves like qbittorrent exactly (except no "Hide" from context menu), i have no opinion for this behavior.

[glassez]

5. shows the application window or brings a previously opened window to the foreground.

Isn't that what we want?

Yes.
But it no more hides window on Windows.
I am quite happy with this behavior if it was also proposed as a feature and would be approved by other members (and, accordingly, would work the same on all platforms). But now it is a regression. So I doubt it can be accepted in this form.
@Chocobo1, @qbittorrent/bug-handlers, what do you think?