-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Draft] Add announce_port support #21692
base: master
Are you sure you want to change the base?
Conversation
// Port to announce to trackers | ||
settingsPack.set_int(lt::settings_pack::announce_port, announcePort()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should guard against libtorrent version here and only here:
// Port to announce to trackers | |
settingsPack.set_int(lt::settings_pack::announce_port, announcePort()); | |
#if LIBTORRENT_VERSION_NUM >= XXXXX // please fill the correct version in | |
// Port to announce to trackers | |
settingsPack.set_int(lt::settings_pack::announce_port, announcePort()); | |
#endif |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the review. I will resolve this item once the merged arvidn/libtorrent#7771 reaches a release.
5ae627b
to
6caafc8
Compare
On a side-note, the |
6caafc8
to
ee04f2e
Compare
This PR is stale because it has been 60 days with no activity. This PR will be automatically closed within 7 days if there is no further activity. |
Warning
Draft pending next release including arvidn/libtorrent#7771
The
announce_port
setting permits to overwrite the port passed along to trackers as the&port=
parameter. If left as the default, the listening port is used. This setting is only meant for very special cases where a seed's listening port differs from the effectively exposed port (e.g., through external NAT-PMP). See arvidn/libtorrent#7771 for an example use-case.This PR adds the relevant setting alongside the existing
announce_ip
setting.The setting subsequently modifies the announced port (
&port=1234
):