-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support fetching tracker list from URL #21828
base: master
Are you sure you want to change the base?
Conversation
I see only 1 problem: The box for |
Supersedes? #20115 |
In my testing, the height is unchanged compared to
Ah yes - I hadn't noticed that PR. These seem to be based off of the same original code. |
6878119
to
2e1afc4
Compare
Tested! Did not test WebUI. |
I maintain https://github.com/ngosang/trackerslist since 8 years ago and I will keep maintaining it. It's used by several opensource projects. I have been contributor of qBittorrent long time ago too. You can add it as default if you want to. |
The reason I opted not to include a default tracker list was due to potential legal concerns. If this isn't an issue, I can use your list. (cc @qbittorrent/lead-developers) |
I think adding a default link is not a good idea. Everyone uses different services with a list of trackers, I use https://newtrackon.com/. |
2e1afc4
to
5ae679a
Compare
5ae679a
to
d1ba9a4
Compare
@@ -749,6 +764,9 @@ namespace BitTorrent | |||
bool m_IPFilteringConfigured = false; | |||
mutable bool m_listenInterfaceConfigured = false; | |||
|
|||
QString m_additionalTrackersFromURL; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems you don't really need this since you already have m_additionalTrackerEntriesFromURL
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is mostly useful for the comparison against the existing tracker list to determine if we need to call populateAdditionalTrackersFromURL()
, though it's also used to get the list of trackers to display. We could instead do the comparison against QList<TrackerEntry> m_additionalTrackerEntriesFromURL
and parse this every time, but it seemed easier to keep around the QString
.
Trackers specified at the URL will be added to newly added public torrents.
d1ba9a4
to
e98bd4f
Compare
This feature is adapted from qBittorrent-Enhanced-Edition to allow for automatically adding trackers retrieved from a URL. @ngosang's trackerlist repo is a good example, however I've opted not to include a default URL.
Partially addresses #14535.