-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for renaming plugin name #302
Conversation
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #302 +/- ##
==========================================
- Coverage 37.76% 34.57% -3.19%
==========================================
Files 96 67 -29
Lines 3948 3803 -145
==========================================
- Hits 1491 1315 -176
- Misses 2457 2488 +31 ☔ View full report in Codecov by Sentry. |
Hi @Xpirix , can you add unit tests please? |
thanks, Hard for me to understand the PR, but in case we can have new name set and upload new version of the plugin that will not override this new name I am fine :) |
That's right. The new name will not change until the admin allows to read it from |
Hi @dimasciput , Thank you for reminding me. I've added unit testing for the plugin's rename feature. |
So for me as plugin admin, what steps I need to do to update plugin visible name? I am bit confused |
Apologies for omitting the details in my previous message. Please refer to the screenshot and steps below for guidance on renaming a plugin via the administration page: Plugin Renaming in the Administration Page
Renaming a Plugin in a New VersionWhen an admin/owner uploads a new version with a name that doesn't match the existing one, an error will be triggered. To override this restriction, administrators can enable the "Allow Update Name" option by checking the corresponding checkbox as mentionned here. |
This is what I do not understand: as a plugin developer, I thought I thought that as plugin developer
I assume "Allow Update Name" = |
You are absolutely right. Thanks for the feedbak. I just fixed that. There is no more error when you upload a plugin zip with the old name that is different form the new name. These processes are correct:
|
👏 |
Great, let me know when this is released, so we can fix the name of Mergin plugin. Thanks! |
@PeterPetrik Sure, we will let you know when this is released. |
Dear @PeterPetrik, these changes are now released on the plugin website. |
Very good, thanks |
My pleasure. |
Please find in here the details for this PR