preserve MDAL mesh metadata when editing mesh layers

[uclaros]

Description

When editing mesh layers, all MDAL mesh metadata are dropped from the modified file. This can break formats that rely on that metadata, like the mike21 format.

This PR makes sure the MDAL mesh metadata are read when loading the mesh and stored back to the output file when editing is finished.

[github-actions]

🪟 Windows builds ready!

Windows builds of this PR are available for testing here. Debug symbols for this build are available here.

(Built from commit 7ce7d5e)

[nyalldawson]

Can you add a test for this?

[uclaros]

Can you add a test for this?

At the moment the MDAL mesh metadata are only used by the ply format which is not good for preserving them perfectly (eg comments can be renamed, leading/trailing whitespaces may be ignored etc)

There is a pending PR that adds metadata handling to mike21 format, I can add a test when this change lands into QGIS.

[nyalldawson]

Is the clang tidy warning correct here?

[uclaros]

Is the clang tidy warning correct here?

This warning is about existing code and not related to this PR.

There seem to be calls to virtual methods during construction, but the proper method is called on runtime. Is that because the base class is abstract and has no implementation for them?

[nyalldawson]

@uclaros I'd add a "final" annotation to the virtual method override -- that should fix the warning

[github-actions]

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

• that all unit tests are passing

• that all comments by reviewers have been addressed

• that there is enough information for reviewers, in particular

  • link to any issues which this pull request fixes

  • add a description of workflows which this pull request fixes

  • add screenshots if applicable

• that you have written unit tests where possible
  In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
  If there is no further activity on this pull request, it will be closed in a week.

[github-actions]

While we hate to see this happen, this PR has been automatically closed because it has not had any activity in the last 21 days. If this pull request should be reconsidered, please follow the guidelines in the previous comment and reopen this pull request. Or, if you have any further questions, just ask! We love to help, and if there's anything the QGIS project can do to help push this PR forward please let us know how we can assist.