Implement QgsGeometry.as_numpy and .as_shapely #58589
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rouault
reviewed
Sep 5, 2024
python/PyQt6/core/__init__.py.in
Outdated
| @@ -540,6 +540,7 @@ QgsException.__doc__ = "Defines a QGIS exception class." | |||
|
|
|||
| try: | |||
| import numpy as _numpy | |||
| import shapely as _shapely | |||
There was a problem hiding this comment.
shapely related things should be put in another try block, so that the raster part can work only if numpy is available
|
What about geometries with Z/M coordinates? |
By utilizing QgsGeometry.asWkb() this is ~8.45 times faster than the previous implementation.
nyalldawson
reviewed
Sep 11, 2024
python/PyQt6/core/__init__.py.in
Outdated
| def _geometry_as_shapely(self) -> _shapely.geometry.base.BaseGeometry: | ||
| wkb_qbytearray = self.asWkb() # Get the geometry in WKB format (QByteArray) | ||
| wkb_bytes = bytes(wkb_qbytearray) | ||
| shapely_geom = _shapely.from_wkb(wkb_bytes) |
There was a problem hiding this comment.
Does this work? It would save a copy of the data, and might squeeze out a bit more performance:
Suggested change
| shapely_geom = _shapely.from_wkb(wkb_bytes) | |
| shapely_geom = _shapely.from_wkb(wkb_qbytearray.data()) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds methods to QgsGeometry to convert it to a (list of) numpy array(s) or shapely object(s). This is part of qgis/QGIS-Enhancement-Proposals#227. This enhancement improves integration with NumPy and Shapely while keeping them an optional dependency.