Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix vector digitizing truncating geometry precision decimals #58597

Conversation

ViperMiniQ
Copy link
Contributor

#58351

Digitizing box still uses the same QLocale to show values, but instead of the default precision of 6, it now has a precision of 15. After 4 decimals, it changes to scientific notation, depending on the user set locale settings.
As the same object is used to convert values to and from, scientific notation is a valid representation, both for showing the actual values and for saving.

Copy link
Contributor

@nirvn nirvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an OK which should never have been there to begin with :) when that's fixed, we can merge.

src/app/qgsvectorlayerdigitizingproperties.cpp Outdated Show resolved Hide resolved
src/app/qgsvectorlayerdigitizingproperties.cpp Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Sep 16, 2024

🪟 Windows builds ready!

Windows builds of this PR are available for testing here. Debug symbols for this build are available here.

(Built from commit 1be4c2a)

Co-authored-by: Loïc Bartoletti <[email protected]>
Copy link

github-actions bot commented Oct 1, 2024

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

@github-actions github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Oct 1, 2024
@nyalldawson nyalldawson merged commit b130896 into qgis:master Oct 1, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Uh oh! Seems this work is abandoned, and the PR is about to close.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants