fix: [Snyk] Security upgrade vue from 2.7.14 to 3.0.0 #58608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@elpaso is this legit? Looks suspicious to me... |
What about this is suspicious? |
|
It looks legit but it breaks the build: https://github.com/qgis/QGIS/actions/runs/10760791211/job/29844521868?pr=58608#step:10:6614 It probably needs manual adjustments. |
Is "It" in this case the pr or the build? |
The PR needs changes in order to fix the build. Also, you need to make sure that the generated JS code actually works after the updates (that should be done manually). |
…/src/landingpage/yarn.lock to reduce vulnerabilities The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-POSTCSS-5926692
tygyh
force-pushed
the
snyk-fix-fba207964f9a200e32c7914b6c627671
branch
from
39caa6b
to
f77c39a
Compare
|
I don't know where to find the ninja tests to figure out what is wrong |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following vulnerabilities are fixed with an upgrade:
Description
Automated update by Snyk to fix a vulnerability in vue.
See the generated PR for more details