Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport queued_ltr_backports] Don't show font size preview in font button icons #58674

Merged
merged 1 commit into from
Sep 30, 2024
Merged

[Backport queued_ltr_backports] Don't show font size preview in font button icons #58674

merged 1 commit into from
Sep 30, 2024

Conversation

qgis-bot
Copy link
Collaborator

Backport #58673
Authored by: @nyalldawson

@github-actions github-actions bot added this to the 3.40.0 milestone Sep 12, 2024
@nyalldawson nyalldawson force-pushed the queued_ltr_backports branch 2 times, most recently from fddfee5 to 50e3acf Compare September 14, 2024 03:25
@nyalldawson
Don't show font size preview in font button icons
34f719a 
Just reset the font size to a standard size when generating the
preview, otherwise we end up with invisible text on the buttons
if the font size is too big or too little.
@nyalldawson nyalldawson force-pushed the backport-58673-to-queued_ltr_backports branch from b729a3a to 34f719a Compare September 14, 2024 03:29
@github-actions GitHub Actions
Copy link

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

@github-actions github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Sep 29, 2024
@nyalldawson nyalldawson removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Sep 29, 2024
@nyalldawson nyalldawson merged commit be4300f into queued_ltr_backports Sep 30, 2024
29 checks passed
@nyalldawson nyalldawson deleted the backport-58673-to-queued_ltr_backports branch September 30, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nirvn nirvn nirvn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.40.0
Development

Successfully merging this pull request may close these issues.
3 participants
@qgis-bot @nirvn @nyalldawson