Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve UX of layer style categories with html #58729

Merged
merged 9 commits into from
Oct 9, 2024

Conversation

signedav
Copy link
Contributor

@signedav signedav commented Sep 13, 2024

What means we provide displayRole in html format and have a delegate for the display text.

Description

There is a mess in the categories (see #58432 and #45146)

To reorder them would break backwards compatibility (what doesn't mean that we should not do it). But meanwhile this UX only improvement should help in the meantime.

image

  • The grey texts are more descriptive and always there (because tooltips are nice, but if you don't know about them you won't look for them)

  • There are new icons for layer configuration (without being mistaken with the source, fields (contains a small forms in there, to indicate it's a little bit more than just the fields) and notes (was missing before)

  • Model and Delegate are now available in the API

  • Improve design (grey)

  • word wrap

  • Improve texts with info from Copy/paste style category "Form" is missing some settings #45146 (comment)

  • maybe better icons ( an notes icon)

  • expose in the API (to ensure plugins using the same)

@github-actions github-actions bot added this to the 3.40.0 milestone Sep 13, 2024
Copy link

github-actions bot commented Sep 13, 2024

🪟 Windows builds ready!

Windows builds of this PR are available for testing here. Debug symbols for this build are available here.

(Built from commit 816da02)

@kannes
Copy link
Contributor

kannes commented Sep 13, 2024

Nice! I think it could look a bit less busy if the longer, informative lines used a grey or thinner or smaller font.

@signedav
Copy link
Contributor Author

Nice! I think it could look a bit less busy if the longer, informative lines used a grey or thinner or smaller font.

Thanks. I tried italic and it seemed noisy. Maybe grey would be worth a try...

@nyalldawson nyalldawson added the Freeze Exempt Feature Freeze exemption granted label Sep 13, 2024
@nirvn
Copy link
Contributor

nirvn commented Sep 14, 2024

@signedav , good move, that'll help guide people through this otherwise relatively obscure set of categories. +1 to maybe have the text grayed out and/or slightly smaller (relative to main font app size).

I've not compiled it so maybe it does already, but list should allow for the description text to wrap to new lines when the dialog is narrower than the screenshot above.

@signedav
Copy link
Contributor Author

Opinions on that @nirvn @kannes ?

grey small grey-and-small
Screenshot from 2024-09-14 23-08-37 Screenshot from 2024-09-14 23-09-49 Screenshot from 2024-09-14 23-05-02

I like the look of the smaller font, but I would rather "not read" it than the grey one.
Anyway I'm -1 to have small and grey.

Copy link
Contributor

@pathmapper pathmapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, really helpful!

Maybe add also an icon for "Notes" to have the text aligned with the other categories? (a sticky note symbol would perhaps fit)

I'm +1 for the grey variant, but would also be fine with the others as this is in general an improvement.

src/gui/qgsmaplayerstylecategoriesmodel.cpp Outdated Show resolved Hide resolved
src/gui/qgsmaplayerstylecategoriesmodel.cpp Outdated Show resolved Hide resolved
@kannes
Copy link
Contributor

kannes commented Sep 18, 2024

+1 for grey

@signedav signedav marked this pull request as ready for review September 24, 2024 16:22
@fiddlersfan
Copy link
Contributor

Nice work, thanks! Just a small visual inconstancy in night mapping at the note icon:

I would suggest coloring the paper white here, similar to the clock icon. Unfortunately, we can then no longer use the mIndicatorNotes icon, which is used as a monochrome icon in the layer overview.

@signedav
Copy link
Contributor Author

Considered that @fiddlersfan

@signedav
Copy link
Contributor Author

signedav commented Oct 7, 2024

Can we merge that? All inputs have been considered.

Copy link
Contributor

@nirvn nirvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this now, I'll give the notes icon a try in the coming weeks.

@signedav signedav merged commit 03f193d into qgis:master Oct 9, 2024
29 checks passed
@signedav signedav deleted the categorizelegate branch October 9, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Freeze Exempt Feature Freeze exemption granted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants