-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve UX of layer style categories with html #58729
Conversation
… introduce a delegate as well)
7c0db86
to
3319b8c
Compare
Nice! I think it could look a bit less busy if the longer, informative lines used a grey or thinner or smaller font. |
Thanks. I tried italic and it seemed noisy. Maybe grey would be worth a try... |
@signedav , good move, that'll help guide people through this otherwise relatively obscure set of categories. +1 to maybe have the text grayed out and/or slightly smaller (relative to main font app size). I've not compiled it so maybe it does already, but list should allow for the description text to wrap to new lines when the dialog is narrower than the screenshot above. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, really helpful!
Maybe add also an icon for "Notes" to have the text aligned with the other categories? (a sticky note symbol would perhaps fit)
I'm +1 for the grey
variant, but would also be fine with the others as this is in general an improvement.
+1 for grey |
352a2a1
to
be10787
Compare
be10787
to
24f7a76
Compare
Considered that @fiddlersfan |
Can we merge that? All inputs have been considered. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge this now, I'll give the notes icon a try in the coming weeks.
What means we provide displayRole in html format and have a delegate for the display text.
Description
There is a mess in the categories (see #58432 and #45146)
To reorder them would break backwards compatibility (what doesn't mean that we should not do it). But meanwhile this UX only improvement should help in the meantime.
The grey texts are more descriptive and always there (because tooltips are nice, but if you don't know about them you won't look for them)
There are new icons for layer configuration (without being mistaken with the source, fields (contains a small forms in there, to indicate it's a little bit more than just the fields) and notes (was missing before)
Model and Delegate are now available in the API
Improve design (grey)
word wrap
Improve texts with info from Copy/paste style category "Form" is missing some settings #45146 (comment)
maybe better icons ( an notes icon)
expose in the API (to ensure plugins using the same)