Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable snapping when the add feature tool is activated on a non-spatial vector layer #58755

Merged
merged 2 commits into from
Sep 29, 2024

Conversation

benwirf
Copy link
Contributor

@benwirf benwirf commented Sep 15, 2024

Description

This PR fixes a reported bug whereby active snapping settings are enabled when adding records to a non-spatial table.

Some logic is also added to manage setting the correct digitizing cursors when switching between spatial and non-spatial vector layer with both in edit mode and add feature tool active.

Fixes #56152

Screenshot showing current behavior (snapping enabled *also note that the open hand cursor persists when switching to a spatial layer in edit mode):

snapping-bug-1

Screenshot showing snapping now disabled when adding records to non-spatial layer.

snapping-bug-2

And with advanced digitizing enabled (also showing better cursor handling)

snapping-bug-3

…ial vector layer.

Also manage digitizing cursors properly when switching between spatial and
non-spatial vector layer with both in edit mode and add feature tool active.

Fixes qgis#56152
Copy link

github-actions bot commented Sep 15, 2024

🪟 Windows builds ready!

Windows builds of this PR are available for testing here. Debug symbols for this build are available here.

(Built from commit 6bf64d1)

@benwirf
Copy link
Contributor Author

benwirf commented Sep 16, 2024

Ping @nirvn

@nyalldawson nyalldawson merged commit 29aa436 into qgis:master Sep 29, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a new record in a table enable the snapping tool
3 participants