Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to delete user profile in Profile Selector (adds #38243) #58763

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Add option to delete user profile in Profile Selector (adds #38243) #58763

wants to merge 11 commits into from

Commits on Sep 14, 2024

  1. Add minimal version of profile deletion from GUI

    @JuhoErvasti
    JuhoErvasti committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    3f9a3f4 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2024

  1. Improve profile deletion 

    - Ask to confirm deletion
- Refresh list of profiles after deletion
- Disallow deleting default profile (not sure if necessary?)
- Check for errors
    @JuhoErvasti
    JuhoErvasti committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    56dbde6 View commit details
    Browse the repository at this point in the history

  2. Change confirmation to QMessageBox::Yes and No 

    - I figure this is better and safer since with Ok and Cancel the default
  option is Ok so a user might accidentally confirm deletion with the
  keyboard, now the default option is No
    @JuhoErvasti
    JuhoErvasti committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    e06c763 View commit details
    Browse the repository at this point in the history

  3. Enable opening profile selector from Profiles menu

    @JuhoErvasti
    JuhoErvasti committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    87a91c4 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. Move open profile selector action to the bottom

    @JuhoErvasti
    JuhoErvasti committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    bc7c7b9 View commit details
    Browse the repository at this point in the history

  2. Strengthen warning about deleting the profile

    @JuhoErvasti
    JuhoErvasti committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    a1eb314 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. Gray out and disable choosing active profile 

    - I think this is clearer and also matches the behaviour of the User
  Profiles menu
- Also add ... to indicate a dialog
    @JuhoErvasti
    JuhoErvasti committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    5eb0a50 View commit details
    Browse the repository at this point in the history

  2. Disable deleting active profile

    @JuhoErvasti
    JuhoErvasti committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    ef9c742 View commit details
    Browse the repository at this point in the history

  3. Use tr()

    @JuhoErvasti
    JuhoErvasti committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    cb80c74 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. Change terminology from removing to deleting

    @JuhoErvasti
    JuhoErvasti committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    3658792 View commit details
    Browse the repository at this point in the history

  2. Pick color from list widget's palette

    @JuhoErvasti
    JuhoErvasti committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    7a44d29 View commit details
    Browse the repository at this point in the history