Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[server] WMS GetLegendGr.. cascading size #58790

Merged

Conversation

elpaso
Copy link
Contributor

@elpaso elpaso commented Sep 18, 2024

Fix #57422 by adjusting the legend size considering the cascaded legend image size.

Fix qgis#57422 by adjusting the legend size considering the
cascaded legend imag size.
@elpaso elpaso added Bug Either a bug report, or a bug fix. Let's hope for the latter! Server Related to QGIS server labels Sep 18, 2024
@github-actions github-actions bot added this to the 3.40.0 milestone Sep 18, 2024
Copy link

github-actions bot commented Sep 18, 2024

🪟 Windows builds ready!

Windows builds of this PR are available for testing here. Debug symbols for this build are available here.

(Built from commit 1f86ad1)

Copy link
Contributor

@troopa81 troopa81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind adding tests?

src/core/layertree/qgslayertreemodellegendnode.h Outdated Show resolved Hide resolved
@elpaso
Copy link
Contributor Author

elpaso commented Sep 20, 2024

Do you mind adding tests?

Well, I considered that and IMHO it doesn't worth the effort, unless there is a way to not involve real network calls to a WMS server to get the legend graphic. AFAIK fake_qgis_http_endpoint is not available in the image fetcher code.

@troopa81 troopa81 merged commit bcaea01 into qgis:master Sep 23, 2024
29 checks passed
@elpaso elpaso deleted the bugfix-gh57422-server-cascading-legend-size branch September 23, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Server Related to QGIS server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QGIS Server: fixed width of 200 px of cascaded WMS layer legends
2 participants