Merge remote and local QgsEptPointCloudIndex classes #59279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
dvdkon
force-pushed
the
ept-remote-merge
branch
from
dcc243d
to
3cffbb2
Compare
dvdkon
force-pushed
the
ept-remote-merge
branch
2 times, most recently
from
c2101b3
to
37bbc44
Compare
dvdkon
force-pushed
the
ept-remote-merge
branch
from
37bbc44
to
aad96a7
Compare
wonder-sk
approved these changes
Nov 13, 2024
| @@ -26,21 +26,31 @@ | |||
| #include <QTime> | |||
| #include <QtDebug> | |||
| #include <QQueue> | |||
| #include <qnetworkrequest.h> | |||
There was a problem hiding this comment.
just for consistency...
Suggested change
| #include <qnetworkrequest.h> | |
| #include <QNetworkRequest> |
|
|
||
| const QDir directory = QFileInfo( fileName ).absoluteDir(); | ||
| mDirectory = directory.absolutePath(); | ||
| QNetworkRequest nr = QNetworkRequest( QUrl( mUri ) ); |
There was a problem hiding this comment.
It looks like in the previous implementation we have forgotten to add marker for the network request, e.g.
QgsSetRequestInitiatorClass( nr, QStringLiteral( "QgsEptPointCloudIndex" ) );
Could you please add it? (and one more when fetching manifest.json and one in loadManifest())
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements part of qgis/QGIS-Enhancement-Proposals#290: It removes
QgsRemoteEptPointCloudIndex, putting its code intoQgsEptPointCloudIndex, which can now be used for both remote and local data.It also slightly refactors
QgsPointCloudIndex, changingnodeChildren()so it uses virtual methods and we don't have to override it, and removing a duplicatenodePointCount()method (confusingly, two variants, const and non-const, existed in different parts of the file).