Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(featurepool): cache management - fixes #58113 #59330

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Djedouas
Copy link
Member

@Djedouas Djedouas commented Nov 4, 2024

This is a PR following the review of #58132 , to facilitate discussion as this is another approach suggested by @nyalldawson .

Geometry checker cache does not work properly with memory layers. refreshCache now handles a list of updated features to be thread-safe.

Also, fixes a locker mode, and correctly remove features from spatial index.

Fixes #58113

@github-actions github-actions bot added this to the 3.42.0 milestone Nov 4, 2024
Copy link

github-actions bot commented Nov 4, 2024

🪟 Windows builds

Download Windows builds of this PR for testing.
Debug symbols for this build are available here.
(Built from commit 178ef4f)

🪟 Windows Qt6 builds

Download Windows Qt6 builds of this PR for testing.
(Built from commit 178ef4f)

Geometry checker cache does not work properly with memory layers.
refreshCache now handles a list of updated features to be thread-safe.

Also, fixes a locker mode, and correctly remove features from spatial
index.
@Djedouas
Copy link
Member Author

Djedouas commented Nov 5, 2024

unrelated test error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QgsFeatureSource not synchronised with QgsVectorLayer for memory provider
1 participant