[vector layer] Fix geometry validity check preventing saving of changes after removing problematic feature(s) #60263
+12
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es after removing problematic feature(s)
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
nyalldawson
reviewed
Jan 24, 2025
| @@ -133,12 +133,16 @@ void QgsGeometryValidationService::onGeometryChanged( QgsVectorLayer *layer, Qgs | |||
|
|
|||
| void QgsGeometryValidationService::onFeatureDeleted( QgsVectorLayer *layer, QgsFeatureId fid ) | |||
| { | |||
| mLayerChecks[layer].singleFeatureCheckErrors.remove( fid ); | |||
There was a problem hiding this comment.
There's a few QHash lookups to mLayerChecks[layer] in this method -- how about retrieving the value once as a reference, and reusing throughout?
There was a problem hiding this comment.
@nyalldawson , addressed, thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #59688 whereas logic was missing to ensure that delete feature(s) with problematic geometry would allow for the remaining valid changes to be saved during an editing session.