Error model output #169
Open
Error model output #169
+6,891
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- generates new action to visualize dada2 stats in a distinct tab format - alters dada2 stats output to be a collection[DADA2Stat] obj -updates existing tests to accommodate this change in data type
-update existing tests to come into line with the new output collection[dada2stats] -adds tests for the output error stats table
-adds tests for the error model vizualization - fixes bug with vizualizing ccs stats
-removing blanks from test files to fix errors in qiime CI
|
Thanks @jordenrabasco! Because this introduces a breaking change (changing the output to a Sound ok? Let us know if you have any questions. Todo:
|
|
@gregcaporaso Of course! That all sounds good to me. In the meantime, let me know if you need me to change anything with the implementation on my end to make it easier for you guys! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is to resolve issue #158
Big changes: