Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: update split to ignore samples that are in the metadata but not the feature table #315

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

gregcaporaso
Copy link
Member

fixes #314

@lizgehret lizgehret self-assigned this Aug 8, 2024
Copy link
Member

@lizgehret lizgehret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this lgtm, thanks @gregcaporaso!

@lizgehret lizgehret changed the title update split to ignore samples that are in the metadata but not the feature table MAINT: update split to ignore samples that are in the metadata but not the feature table Aug 21, 2024
@lizgehret lizgehret merged commit a4d0e2e into dev Aug 21, 2024
5 checks passed
@lizgehret lizgehret assigned gregcaporaso and unassigned lizgehret Aug 21, 2024
@hagenjp hagenjp assigned hagenjp and unassigned gregcaporaso Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

feature-table split fails if there are samples in the metadata that are not in the feature table
3 participants