NEW: Exposes strand parameter for cluster_features_de_novo (#90)
#90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apologies for the delayed review on this @vaamb - implementation looks good, but it would be nice to add some associated unit tests to confirm that this added parameter is functioning as expected! |
|
Hey @vaamb we'll have to bump this to the next release if you aren't able to get unit tests added by EOD tomorrow. Thanks! |
- Used the same default parameters and description than the 2 other `cluster_features_*`
- It was a copy and paste of the comment under `test_skip_denovo`
…and_no_clustering` and `test_99_percent_clustering_strand`
|
@lizgehret I finally found the time to add the tests |
lizgehret
changed the title
strand parameter for cluster_features_de_novostrand parameter for cluster_features_de_novo (#90)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can be usefull when working with mixed-orientation sequences in order to merge together sequences with their reverse complement prior to other analyses
Used the same default parameters and description than for the 2 other
cluster_features_*