-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
install guide updates #3312
install guide updates #3312
Conversation
@@ -181,7 +181,7 @@ github organization. Each of the plugins have their own installation instruction | |||
suggest looking at each individual .travis.yml file to see detailed installation | |||
instructions. Note that the most common plugins are: | |||
- [qtp-biom](https://github.com/qiita-spots/qtp-biom) | |||
- [qtp-target-gene](https://github.com/qiita-spots/qtp-target-gene) | |||
- [qtp-sequencing](https://github.com/qiita-spots/qtp-sequencing) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
qtp-target-gene has been renamed to qtp-sequencing. The old link still works, but it is surprising (and potentially worrying :) to the reader to end up at a different URL than the one they expected.
@@ -206,9 +206,7 @@ Set your `QIITA_CONFIG_FP` environment variable to point to that file (into `.ba | |||
source activate qiita | |||
``` | |||
|
|||
Update paths in the newly copied configuration file to match your settings, e.g. replace /home/travis/ with your user home directory. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are no travis paths in the config anymore.
Update paths in the newly copied configuration file to match your settings, e.g. replace /home/travis/ with your user home directory. | ||
|
||
If you are working on WSL, you will need to start the redis server with the following command before making a test environment: | ||
If you are working on Mac OS X or WSL, you will need to start the redis server with the following command before making a test environment: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Installing on mac (not just WSL) fails if one doesn't run the redis-server start ... ask me how I know :)
Thank you @AmandaBirmingham ! Could you pull from dev ( BTW if you don't have upstream you can do |
Hi, @antgonza Unfortunately I do not think the build issue, whatever it is, is as simple as that. I synced my fork with the qiita-spots:dev branch before beginning this PR ... but just in case I did it wrong :), I have followed the directions you provided, and the message I got was The build failure occurs early on, in the "Install plugins" stage, where it says: Maybe it is some sort of transient problem with bioconductor? I will bump this with a small change and see if I get the same result today ... |
@antgonza Happily, it does look like it was some sort of intermittent bioconductor problem .. building again today with only an added space in the markdown gets everything passing :D |
Thank you! |
Some very small changes to clarify bits of the install guide, based on a trial usage :) ... now directed to the correct branch!
BTW, this PR's build fails, but so did the commit before it, so I don't think this markdown-only change is the cause ;)