Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install guide updates #3312

Merged
merged 2 commits into from
Aug 15, 2023
Merged

install guide updates #3312

merged 2 commits into from
Aug 15, 2023

Conversation

AmandaBirmingham
Copy link
Contributor

Some very small changes to clarify bits of the install guide, based on a trial usage :) ... now directed to the correct branch!

BTW, this PR's build fails, but so did the commit before it, so I don't think this markdown-only change is the cause ;)

@@ -181,7 +181,7 @@ github organization. Each of the plugins have their own installation instruction
suggest looking at each individual .travis.yml file to see detailed installation
instructions. Note that the most common plugins are:
- [qtp-biom](https://github.com/qiita-spots/qtp-biom)
- [qtp-target-gene](https://github.com/qiita-spots/qtp-target-gene)
- [qtp-sequencing](https://github.com/qiita-spots/qtp-sequencing)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

qtp-target-gene has been renamed to qtp-sequencing. The old link still works, but it is surprising (and potentially worrying :) to the reader to end up at a different URL than the one they expected.

@@ -206,9 +206,7 @@ Set your `QIITA_CONFIG_FP` environment variable to point to that file (into `.ba
source activate qiita
```

Update paths in the newly copied configuration file to match your settings, e.g. replace /home/travis/ with your user home directory.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no travis paths in the config anymore.

Update paths in the newly copied configuration file to match your settings, e.g. replace /home/travis/ with your user home directory.

If you are working on WSL, you will need to start the redis server with the following command before making a test environment:
If you are working on Mac OS X or WSL, you will need to start the redis server with the following command before making a test environment:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Installing on mac (not just WSL) fails if one doesn't run the redis-server start ... ask me how I know :)

@antgonza
Copy link
Member

Thank you @AmandaBirmingham ! Could you pull from dev (git pull upstream dev) and push back (git push origin dev)? This should solve the build errors.

BTW if you don't have upstream you can do git remote add upstream https://github.com/qiita-spots/qiita.

@AmandaBirmingham
Copy link
Contributor Author

Hi, @antgonza Unfortunately I do not think the build issue, whatever it is, is as simple as that. I synced my fork with the qiita-spots:dev branch before beginning this PR ... but just in case I did it wrong :), I have followed the directions you provided, and the message I got was Everything up to date (so the push did nothing). I have also verified by manually looking into some of the actual files that your latest commit to qiita-spots:dev has been integrated into this branch, so it isn't an issue of the repos being out of sync.

The build failure occurs early on, in the "Install plugins" stage, where it says:
ERROR conda.core.link:_execute(952): An error occurred while installing package 'bioconda::bioconductor-genomeinfodbdata-1.2.9-r42hdfd78af_0'.
... and this same failure occurred for my fork before I made any changes (see screenshot).
Screenshot 2023-08-14 at 12 11 31 PM

Maybe it is some sort of transient problem with bioconductor? I will bump this with a small change and see if I get the same result today ...

@AmandaBirmingham
Copy link
Contributor Author

@antgonza Happily, it does look like it was some sort of intermittent bioconductor problem .. building again today with only an added space in the markdown gets everything passing :D

@antgonza antgonza merged commit 8929ad0 into qiita-spots:dev Aug 15, 2023
4 checks passed
@antgonza
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants