Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test util db #3406

Merged
merged 11 commits into from
May 21, 2024
Merged

Test util db #3406

merged 11 commits into from
May 21, 2024

Conversation

Gossty
Copy link
Contributor

@Gossty Gossty commented May 8, 2024

Updated test_util.py for ResourceAllocationPlotTests by connecting the tests to database.

Copy link
Member

@antgonza antgonza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some minor comments. @charles-cowart, could you also take a look? Thank you,

qiita_db/test/test_meta_util.py Outdated Show resolved Hide resolved
qiita_db/test/test_user.py Show resolved Hide resolved
qiita_db/test/test_user.py Show resolved Hide resolved
qiita_db/util.py Outdated Show resolved Hide resolved
qiita_db/test/test_util.py Outdated Show resolved Hide resolved
Copy link
Contributor

@charles-cowart charles-cowart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a few comments.

qiita_db/test/test_software.py Outdated Show resolved Hide resolved
qiita_db/test/test_util.py Show resolved Hide resolved
@charles-cowart charles-cowart merged commit 55e460e into qiita-spots:dev May 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants