Add social handles #3412
Merged
Add social handles #3412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…RCID and ResearchGate
|
@antgonza do you have an idea why my PR errors with |
antgonza
requested changes
Jun 4, 2024
Comment on lines
1891
to
1894
| receive_processing_job_emails boolean DEFAULT false, | ||
| social_orcid character varying, | ||
| social_researchgate character varying, | ||
| social_googlescholar character varying |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
Yup, we just merged the fix for that and these tests should run fine. |
|
Looks like you have to pull from dev and then push; could you do that? |
|
Hi @antgonza I made the requested changes and added some tests. Can you give this PR another review? |
charles-cowart
requested changes
Jun 5, 2024
charles-cowart
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #3404, I have extended the user profile edit page with three additional input fields to store social network handles for google scholar, research gate and orcid.
becomes:
Note that I have added WTForm validators to check user input and provide hints if he/she provides wrong inputs. That required a bit of changes in the HTML template as well as in the UserProfileHandler.post method. I've also added small icons for the social networks, which made be use CSS flex box mechanisms to properly align the icon with the label (are we legally allowed to display those?).
Since qiita already uses WTForm mechanism, I opted to simple extend the qiita.qiita_user table by three additional columns, namely those defined by adding additional
StringFieldelements. Everything else (storing, retrieving, updating) came out of the box with existing code.