Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prep-info file generation/Replicate tests added. #69

Merged
merged 9 commits into from
Aug 22, 2023

Conversation

charles-cowart
Copy link
Contributor

SPP's prep-file ingestion needs modification to handle replicate prep-info files.

@charles-cowart charles-cowart changed the title WIP Prep-info file generation/Replicate tests added. Prep-info file generation/Replicate tests added. Aug 3, 2023
@charles-cowart
Copy link
Contributor Author

@antgonza Ready for re-review!

Copy link
Member

@antgonza antgonza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments.

README.rst Outdated Show resolved Hide resolved
qp_klp/Step.py Outdated Show resolved Hide resolved
qp_klp/tests/test_step.py Outdated Show resolved Hide resolved
qp_klp/tests/test_step.py Show resolved Hide resolved
@charles-cowart
Copy link
Contributor Author

@antgonza ready for review!

Copy link
Member

@antgonza antgonza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you confirm if fixing --use-pep517 is something easy or hard? If easy, can you add the fix in this PR so the flag is not necessary?

README.rst Outdated Show resolved Hide resolved
Removing mention. optional pep-switch for installation. Superseded by another PR.
@charles-cowart
Copy link
Contributor Author

Should be ready for review after #72 is merged.

@charles-cowart
Copy link
Contributor Author

@antgonza ready for review!

@antgonza antgonza merged commit 6a3b503 into qiita-spots:main Aug 22, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants