WIP: Added Qiita study reserved-word check #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antgonza
requested changes
Sep 12, 2024
Comment on lines
+1004
to
+1008
| fake_client.info_in_11661['categories'].append('well_id_384') | ||
| fake_client.info_in_13059['categories'].append('well_id_384') | ||
|
|
||
| msg = ("'well_id_384' exists in Qiita study 13059's sample metadata" | ||
| "\n'well_id_384' exists in Qiita study 11661's sample metadata") |
There was a problem hiding this comment.
My concern with this is that we are not actually testing the connection to qiita as you are using the fake_client, would it be possible to create a real one? Note that all plugins use this. See: https://github.com/qiita-spots/qp-woltka/blob/main/qp_woltka/tests/test_woltka.py#L26
There was a problem hiding this comment.
After discussion offline, @charles-cowart confirmed that he's pointing to the right endpoint cause he tested outside of the tests + we agreed that reintroducing actual testing against the local/dev version will be in a different PR.
antgonza
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on an additional PR to mg-scripts before passing tests.