Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update return register accordingly for all arch #1367

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

ucgJhe
Copy link
Collaborator

@ucgJhe ucgJhe commented Jul 28, 2023

update return register accordingly, so setReturnAddress could work as expected.

@elicn
Copy link
Member

elicn commented Jul 30, 2023

I am wondering why these haven't failed so far.. @ucgJhe, did you encounter any failures that brought you to fix these?

Also, would appreciate another pair of eyes that are more familiar with those arch that I do.
@wtdcode, what do you think?

@ucgJhe
Copy link
Collaborator Author

ucgJhe commented Jul 30, 2023

I am wondering why these haven't failed so far.. @ucgJhe, did you encounter any failures that brought you to fix these?

Also, would appreciate another pair of eyes that are more familiar with those arch that I do. @wtdcode, what do you think?

Basically, I've been working on improving function call feature and happened to found this is not in the right place.

@xwings
Copy link
Member

xwings commented Jul 31, 2023

I am wondering why these haven't failed so far.. @ucgJhe, did you encounter any failures that brought you to fix these?
Also, would appreciate another pair of eyes that are more familiar with those arch that I do. @wtdcode, what do you think?

Basically, I've been working on improving function call feature and happened to found this is not in the right place.

interesting. i think you should start to add in some small unit test. i remember u told me the test run too long. but again, incomplete test it ways better better then no test.

@wtdcode
Copy link
Member

wtdcode commented Aug 3, 2023

I am wondering why these haven't failed so far.. @ucgJhe, did you encounter any failures that brought you to fix these?

Also, would appreciate another pair of eyes that are more familiar with those arch that I do. @wtdcode, what do you think?

The comment seems left by me. IIRC, the reason behind the comment is that, depending on the context, the return address may be on stack, say interrupt handlers. Though in most cases for userland code, LR is used instead.

@xwings xwings merged commit 1a92844 into qilingframework:dev Aug 4, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants