Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed DOS Disk Mapping #1439

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Fixed DOS Disk Mapping #1439

wants to merge 1 commit into from

Conversation

racerxdl
Copy link

This fixes the DOS Mappings and makes 8086 examples work again.

This is probably not the best way to fix them, but at least it works fine with current FS Mapper. Basically what it does is map 0x80 to C and beyond and 0x00 to A and beyond.

There is few limitations though: INT 13H actually allows up to 126 disks, this only supports disks from C to Z. INT13 also supports floppies in CDEF... letters, this PR only supports A and B as floppy letters.

Although this is not ideal, I don't think I ever saw something actually uses more than two floppies and few disks. At least this make qiling able to simulate DOS.

Checklist

Which kind of PR do you create?

  • This PR only contains minor fixes.
  • This PR contains major feature update.
  • This PR introduces a new function/api for Qiling Framework.

Coding convention?

  • The new code conforms to Qiling Framework naming convention.
  • The imports are arranged properly.
  • Essential comments are added.
  • The reference of the new code is pointed out.

Extra tests?

  • No extra tests are needed for this PR.
  • I have added enough tests for this PR.
  • Tests will be added after some discussion and review.

Changelog?

  • This PR doesn't need to update Changelog.
  • Changelog will be updated after some proper review.
  • Changelog has been updated in my PR.

Target branch?

  • The target branch is dev branch.

One last thing


@elicn elicn self-assigned this Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants