Qdb bug fix missing function handle_bnj_arm
#1483
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dict for handling address preference
wtdcode
approved these changes
Jul 14, 2024
elicn
reviewed
Jul 16, 2024
| prophecy = self.Prophecy() | ||
| cur_addr = self.cur_addr | ||
| cur_addr = pref_addr or self.cur_addr |
There was a problem hiding this comment.
Please note that the or operator will pick the latter not only when the former is None, but also when it is 0. If 0 is a valid value for pref_addr, then consider using:
cur_addr = self.cur_addr if pref_addr is None else pref_addrThere was a problem hiding this comment.
thx for the hint, i will correct this in the following fix for the issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix miss-handled funciton
handle_bnj_arm