Update: use is.character instead of inherits to check type

qinwf · Apr 23, 2016 · accbed0 · accbed0
1 parent 1a9f78b
commit accbed0
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/R/extract.R b/R/extract.R
@@ -45,7 +45,7 @@
 #' re2_extract("[email protected]", "(.*)@([^.]*)", "\\2!\\1")
 #' @export
 re2_extract = function(input, pattern, rewrite = "\\1", ...) {
-    if (!inherits(pattern, "re2exp")) {
+    if (is.character(pattern)) {
         pattern = re2(pattern, ...)
     }
     cpp_extract(input, pattern, rewrite)

diff --git a/R/match.R b/R/match.R
@@ -66,7 +66,7 @@ re2_match = function(input,
                      anchor = "none",
                      all = FALSE,
                      ...) {
-    if (!inherits(pattern, "re2exp")) {
+    if (is.character(pattern)) {
         pattern = re2(pattern, ...)
     }
     cpp_match(input, pattern, value, anchor, all)

diff --git a/R/replace.R b/R/replace.R
@@ -49,7 +49,7 @@
 #' re2_replace("yabba dabba doo", "b+","d", all = FALSE) == "yada dabba doo"
 #' @export
 re2_replace = function(input, pattern, rewrite,  all = FALSE, ...) {
-    if (!inherits(pattern, "re2exp")) {
+    if (is.character(pattern)) {
         pattern = re2(pattern, ...)
     }
     cpp_replace(input, pattern, rewrite,  all)