Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploy documentation in qiskit.org/ecosystem #1096

Merged
merged 4 commits into from
Apr 14, 2023

Conversation

1ucian0
Copy link
Contributor

@1ucian0 1ucian0 commented Mar 21, 2023

Similar to Qiskit/qiskit-aer#1748, see Qiskit/qiskit.org#3038 for more context

Summary

The Qiskit Ecosystem lives in qiskit.org/ecosystem and new place for qiskit related projects that are not technically Qiskit. This PR adds that destination for documentation deployment.

Details and comments

For now, a copy of the same docs in ecosystem would allow to have both q.o/documentation and q.o/ecosystem for testing that everything is fine. Once that's done, the CDN will redirects to the new location and the deploy to q.o/documentation can be removed.

@coruscating
Copy link
Collaborator

@1ucian0 will the /documentation to /ecosystem redirect persist forever so that links that are hard to update aren't broken?

@1ucian0
Copy link
Contributor Author

1ucian0 commented Mar 22, 2023

will the /documentation to /ecosystem redirect persist forever so that links that are hard to update aren't broken?

yes

@coruscating
Copy link
Collaborator

@1ucian0 Thanks for this! I updated the link in a few more places and the dev branch docs build script too. If this looks good to you then we can merge.

@coruscating coruscating modified the milestones: Release 0.5, Release 0.6 Mar 28, 2023
@coruscating
Copy link
Collaborator

@1ucian0 I've reverted the link changes, does it look ok now?

Copy link
Contributor

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me, since the redirect is now in place we probably don't need dual upload anymore since only one path is externally accessible. Also, we probably should update the URLs in the links. But we can do that in a follow up easily enough.

@coruscating coruscating added this pull request to the merge queue Apr 14, 2023
@mtreinish mtreinish removed this pull request from the merge queue due to a manual request Apr 14, 2023
@mtreinish
Copy link
Contributor

I've temporarily removed this from the merge queue because I'm running a manual rclone to update the copy of the docs at ecosystem/ from the current version at documentation/ after that finishes I'll re-enqueue it.

@mtreinish mtreinish removed the on hold On hold until something else is done. label Apr 14, 2023
@mtreinish mtreinish added this pull request to the merge queue Apr 14, 2023
Merged via the queue into qiskit-community:main with commit b05dc3d Apr 14, 2023
@1ucian0 1ucian0 deleted the docs_to_ecosystem branch April 15, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants