Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new Furo theme #1225

Merged
merged 8 commits into from
Jul 19, 2023
Merged

Conversation

coruscating
Copy link
Collaborator

@coruscating coruscating commented Jul 13, 2023

Summary

This PR switches the docs to the new Furo ecosystem theme.

image

Details and comments

New build variables have been added:

  • FULL_TOCTREE builds the full API toctree when turned on. By default, this is off for a fast build time and small file sizes. This is turned on for deployments. See Furo: investigate slow builds Qiskit/qiskit_sphinx_theme#328 for more info.
  • VERSION_STRING and RELEASE_STRING are exposed so that the site can display an alternative version/release for builds. This is relevant for the dev site, where we would like to see the git describe commit string instead of the version to be clearer to users. The new theme currently does not expose the version/release (except for the release in the page title) since it doesn't have breadcrumbs, but this will be added after Furo: Add breadcrumb menu Qiskit/qiskit_sphinx_theme#361.

Current known issues:

The experiment gallery doesn't render correctly by default, so the CSS is inserted manually via _static/nbsphinx-gallery.css.

@@ -16,7 +16,6 @@

import os
import sys
import subprocess
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was an unused import.

.. toctree::
:hidden:

Qiskit Experiments Home <self>
Getting Started <tutorials/getting_started>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding Getting Started as a separate menu item to follow the recommended site structure: https://github.com/Qiskit/qiskit_sphinx_theme#tip-suggested-site-structure

@CLAassistant
Copy link

CLAassistant commented Jul 18, 2023

CLA assistant check
All committers have signed the CLA.

docs/conf.py Outdated Show resolved Hide resolved
Copy link
Contributor

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huzzah!

@@ -0,0 +1,31 @@
.nbsphinx-gallery {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a comment explaining what's going on. Or even better, open a GitHub issue and link to it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curve Analysis <tutorials/curve_analysis>
Visualization <tutorials/visualization>
Custom Experiments <tutorials/custom_experiment>

.. toctree::
:hidden:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be hidden? Another option is to set :maxdepth: 1 or 2.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's supposed to be hidden or the entire ToC gets rendered after the page contents:
image

This toctree is only used to register those links for the sidebar.

@coruscating coruscating added this pull request to the merge queue Jul 19, 2023
Merged via the queue into qiskit-community:main with commit d9a767b Jul 19, 2023
@coruscating coruscating deleted the update-docs-theme branch July 21, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants