Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.11 #263

Merged
merged 6 commits into from
Aug 16, 2023
Merged

Conversation

woodsp-ibm
Copy link
Member

@woodsp-ibm woodsp-ibm commented May 3, 2023

Summary

Following Python 3.11 support being added to the other application repos, in particular Qiskit Optimization which this uses, by qiskit-community/qiskit-optimization#481, the support for 3.11 is now added here to Qiskit Finance.

Details and comments

This initial step updates the set of files, such that they linted, passed tests etc locally under 3.11. I want first to check that this all works across the present set of OS's and Python versions and then I will add Python 3.11 jobs to CI.

  • Include 3.11 in workflows
  • Reno

@woodsp-ibm woodsp-ibm changed the title Add support for Python 3.11 [WIP] Add support for Python 3.11 May 3, 2023
@coveralls
Copy link

coveralls commented May 3, 2023

Pull Request Test Coverage Report for Build 4919762076

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 75.793%

Totals Coverage Status
Change from base Build 4912573403: 0.0%
Covered Lines: 645
Relevant Lines: 851

💛 - Coveralls

@woodsp-ibm
Copy link
Member Author

More detail for reason for dropping back on Windows to 3.10 as upper bound job

UnsatisfiableError: The following specifications were found
to be incompatible with the existing python installation in your environment:

Specifications:

  - cvxpy -> python[version='>=3.10,<3.11.0a0|>=3.8,<3.9.0a0|>=3.9,<3.10.0a0|>=3.7,<3.8.0a0|>=3.6,<3.7.0a0']

Your python: python=3.11

@woodsp-ibm woodsp-ibm added the stable backport potential The bug might be minimal and/or import enough to be port to stable label May 4, 2023
@woodsp-ibm woodsp-ibm added the on hold Can not fix yet label May 9, 2023
@woodsp-ibm
Copy link
Member Author

woodsp-ibm commented May 9, 2023

Although this is ready to be merged into main - given the branch protection rules are updated accordingly - I would want to backport this to stable so Finance can support 3.11 when Optimization, on which Finance is dependent, does. This is therefore needs optimization releasing first since stable is run against the released packages not the dev branch, Hence I marked it on hold until the Optimization is next released.

@CLAassistant
Copy link

CLAassistant commented Jun 7, 2023

CLA assistant check
All committers have signed the CLA.

@woodsp-ibm woodsp-ibm removed stable backport potential The bug might be minimal and/or import enough to be port to stable on hold Can not fix yet labels Aug 16, 2023
@woodsp-ibm woodsp-ibm changed the title [WIP] Add support for Python 3.11 Add support for Python 3.11 Aug 16, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5880896932

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 75.793%

Totals Coverage Status
Change from base Build 5238973525: 0.0%
Covered Lines: 645
Relevant Lines: 851

💛 - Coveralls

@woodsp-ibm woodsp-ibm merged commit 682218f into qiskit-community:main Aug 16, 2023
14 checks passed
@woodsp-ibm woodsp-ibm deleted the py311 branch August 16, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants