Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added airbridges to QGDSRenderer #962

Open
wants to merge 59 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
59 commits
Select commit Hold shift + click to select a range
2a4e33c
added QComponent representing Airbridge for GDS
Jun 26, 2023
06b43bc
Merge branch 'airbridges' of https://github.com/clarkmiyamoto/qiskit-…
Jun 26, 2023
7d44837
more airbridge stuff
Jun 27, 2023
b1d75e5
correct pathing for Airbridge_forGDS
Jun 27, 2023
ba1a21d
should be working??? time to test
Jun 27, 2023
2e1b955
added pathing for Airbridging
Jun 27, 2023
6ec3837
fixed typo in make_uniform_airbridging
Jun 27, 2023
03a30f3
added bridge_minimum_spacing to default_options
Jun 27, 2023
7b9632a
fixed typo in extract_qgeom_from_unrendered_qcomp
Jun 27, 2023
afbd457
fixed variable assignment error in Airbridge_forGDS
Jun 27, 2023
61761c8
typo in Airbridge_forGDS
Jun 27, 2023
bb7514c
fixed typo in make_uniform_airbridging_df
Jun 27, 2023
e2d5dc9
fixed typo in make_uniform_airbridging_df
Jun 27, 2023
3cc56b2
fixed cpw_with_ab property
Jun 27, 2023
63c1d6f
fixed self reassignment of ab_placement_to_df
Jun 27, 2023
5824996
fixed bug where ab_placement_to_df didn't save data
Jun 27, 2023
8d64e7f
fixed typo in make_uniform_airbridging_df
Jun 27, 2023
7317803
test
Jun 27, 2023
c134e0d
forgot to import draw in make_airbridge.py
Jun 27, 2023
0cdc8c5
fixed typo in cpws_with_ab
Jun 27, 2023
5f70178
fixed typo in cpws_with_ab
Jun 27, 2023
b5d5396
fixed find_uniform_ab_placement
Jun 27, 2023
af264c1
add float casting to find_uniform_ab_placement
Jun 27, 2023
52eec98
fixed precision error
Jun 27, 2023
6e0875c
reworked self.precision
Jun 27, 2023
9dd9679
forgot to reference self in ab_placement_to_df
Jun 27, 2023
3a8dda3
fixed output of find_uniform_ab_placement
Jun 27, 2023
ec9dcf4
fixed keyerror
Jun 27, 2023
bbba191
fixed typo in calling _multipolygon_to_gds
Jun 27, 2023
2ca5f96
added MultiPoly
Jun 27, 2023
f599ed0
maybed fixed ab_placement_to_df
Jun 27, 2023
a184cc8
typo
Jun 27, 2023
4874446
updates self.chip_info
Jun 27, 2023
276269d
should push to gds
Jun 27, 2023
0722e4a
should push to gds
Jun 27, 2023
4cc60f6
fixed rotation of ab
Jun 27, 2023
2bbac99
fixed rotation of ab
Jun 27, 2023
63a09fb
fixed rotation of ab
Jun 27, 2023
7167ff7
fixed depreciation warning
Jun 27, 2023
b04f902
couldn't fix depreciation error, will leave for someone else
Jun 27, 2023
2ea6c29
added documentation
Jun 27, 2023
bc1ec37
added basic tests
Jun 27, 2023
79977e2
yapf styling
Jun 27, 2023
728e72d
yapf in test
Jun 27, 2023
d37bf2f
fixed error in data_type parsing in _make_uniform_airbridging_df
Jun 27, 2023
eb5dbf8
default_options.airbrdige.datatype isn't loading
Jun 27, 2023
8befcc8
logger works now
Jun 27, 2023
bfb3e15
removed unnessary arg in _make_uniform_airbridging_df
Jun 27, 2023
af5c54e
fixed spelling of outer
Jun 27, 2023
ddfb065
fixed airbridge.py drawing
Jun 27, 2023
1bbea15
update QGDS tutorial to include how to use airbridges
Jun 27, 2023
5af5df4
update QGDS tutorial to include how to use airbridges
Jun 27, 2023
9bb2f43
fixed typo in MPL test
Jun 27, 2023
ef0e92b
add robust test to airbridging
Jun 27, 2023
a0ac02c
fixed tests
Jun 27, 2023
9f8edd5
fixed yapf in tests
Jun 27, 2023
4e95215
typo in test_renderer_gdsrenderer_high_level
Jun 27, 2023
9b5e9bf
typo in test
Jun 27, 2023
bf8de84
Merge branch 'main' into airbridges
zlatko-minev Sep 26, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test
  • Loading branch information
clarkmiyamoto committed Jun 27, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit 73178034402bf0cb0656701268bde972e30c0ebd
6 changes: 2 additions & 4 deletions qiskit_metal/renderers/renderer_gds/make_airbridge.py
Original file line number Diff line number Diff line change
@@ -67,8 +67,7 @@ def make_uniform_airbridging_df(self,
custom_qcomponent: 'QComponent',
qcomponent_options: dict,
bridge_pitch: str,
bridge_minimum_spacing: str,
) -> pd.DataFrame:
bridge_minimum_spacing: str) -> pd.DataFrame:
"""
Makes the uniform airbridging dataframe

@@ -228,8 +227,7 @@ def find_uniform_ab_placement(self,

return ab_placements

def ab_placement_to_df(ab_placement: list[float],
qgeom_table: 'geopandas.geodataframe.GeoDataFrame') -> pd.DataFrame:
def ab_placement_to_df(ab_placement: list[float], qgeom_table: 'pd.DataFrame') -> pd.DataFrame:
'''
With a base airbridge shape, find the shapely data for placing all airbridges.