Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop python 3.7 support #538

Merged
merged 6 commits into from
Aug 22, 2023
Merged

Drop python 3.7 support #538

merged 6 commits into from
Aug 22, 2023

Conversation

t-imamichi
Copy link
Collaborator

@t-imamichi t-imamichi commented Aug 21, 2023

Summary

Qiskit has dropped support Python 3.7 and this follows suit for Qiskit Optimization.
follows qiskit-community/qiskit-finance#288

depends on #536

Details and comments

@t-imamichi t-imamichi changed the title Deprecate python 3.7 Drop python 3.7 support Aug 21, 2023
@woodsp-ibm
Copy link
Member

pyproject.toml and tox.ini both have py37 entries that should be removed too

@coveralls
Copy link

coveralls commented Aug 21, 2023

Pull Request Test Coverage Report for Build 5940174572

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.416%

Totals Coverage Status
Change from base Build 5932990441: 0.0%
Covered Lines: 4448
Relevant Lines: 4813

💛 - Coveralls

@t-imamichi
Copy link
Collaborator Author

t-imamichi commented Aug 22, 2023

@woodsp-ibm I guess we need to configure somewhere to update the following entries to Python 3.8. Do you have any ideas? We can update the configuration after merging this PR.
image

@woodsp-ibm
Copy link
Member

woodsp-ibm commented Aug 22, 2023

I guess we need to configure somewhere to update the following entries to Python 3.8. Do you have any ideas? We can update the configuration after merging this PR.

@t-imamichi They are edited under the Settings for the repo - select Branches from the left and you will see Branch Protection Rules and you can Edit the rules for the main branch. Should probably make sure the new 3.11 tutorials is required too. Once you edit the rules the checks here should alter accordingly. (I think all the checks listed we have as required normally - except the Summary one mergify puts in there).

Don't forget also the comment above about the two other files that should be updated - i.e the removal of py37 in them now that this drops 3.7 support etc.

@t-imamichi
Copy link
Collaborator Author

Thanks. I succeeded in updating the configuration.

@woodsp-ibm
Copy link
Member

woodsp-ibm commented Aug 22, 2023

Looks good, just missing these two file being updated to remove py37 envs

envlist = py37, py38, py39, py310, py311, lint

target-version = ['py37', 'py38', 'py39', 'py310']

And I note in the latter (pyproject.toml) we forgot to add py311 to that list for black so maybe that can be added, and we can fix it here, while removing the py37

@t-imamichi
Copy link
Collaborator Author

Thanks. I updated tox.ini and pyproject.toml.

Copy link
Member

@woodsp-ibm woodsp-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 2c0b02c into qiskit-community:main Aug 22, 2023
17 checks passed
@t-imamichi t-imamichi deleted the dep37 branch August 22, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge type: ci Related to CI changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants