Switch from qiskit-terra to qiskit #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 6039389291
💛 - Coveralls |
t-imamichi
approved these changes
Sep 1, 2023
woodsp-ibm
added
the
stable backport potential
mergify bot
pushed a commit
that referenced
this pull request
Sep 1, 2023
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 12d63bc) # Conflicts: # .github/actions/install-main-dependencies/action.yml # .github/workflows/main.yml # tox.ini
woodsp-ibm
removed
the
stable backport potential
|
I labelled this stable backport by mistake!!! I had intended to do the master->main switch one for the translatable strings. I closed the backported PR with a similar comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Similar to qiskit-community/qiskit-machine-learning#680
Switches over to
qiskitfromqiskit-terraThere was no Neko integration/workflow here to be removed (unlike ML)
I also updated a couple of places that referred to Terra (I was searching for Terra) in all the files. I guess I could have commented in #537 and had it done there, since this is now referring to qiskit_algorithms as the source of algorithms not Terra and while it had changed one occurrence in the main init file, I did not see it touching these files and figured I would just do it here since its really only a single line change in each.
Details and comments
I am starting here, unlike with ML, with the setting here for the default stable install. The changes to install from source I checked out on ML so they work - we could check it out here too if needed just in case I made a slip. I compared the changes and things look comparable so it all seems fine.