Fix incorrect decoding of decision variables by MagicRounding
#627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yksat
requested review from
stefan-woerner,
woodsp-ibm and
t-imamichi
as code owners
|
|
|
|
Pull Request Test Coverage Report for Build 10277826007Details
💛 - Coveralls |
t-imamichi
reviewed
Aug 6, 2024
t-imamichi
added
Changelog: Bugfix
Co-authored-by: Takashi Imamichi <[email protected]>
t-imamichi
reviewed
Aug 7, 2024
Co-authored-by: Takashi Imamichi <[email protected]>
t-imamichi
approved these changes
Aug 7, 2024
mergify bot
pushed a commit
that referenced
this pull request
Aug 9, 2024
* Minor fixes * Add files via upload * Add files via upload * simplify iterator expression Co-authored-by: Takashi Imamichi <[email protected]> * modify releasenotes Co-authored-by: Takashi Imamichi <[email protected]> --------- Co-authored-by: Takashi Imamichi <[email protected]> (cherry picked from commit 807d481)
mergify bot
added a commit
that referenced
this pull request
Aug 9, 2024
…) (#633) * Minor fixes * Add files via upload * Add files via upload * simplify iterator expression Co-authored-by: Takashi Imamichi <[email protected]> * modify releasenotes Co-authored-by: Takashi Imamichi <[email protected]> --------- Co-authored-by: Takashi Imamichi <[email protected]> (cherry picked from commit 807d481) Co-authored-by: Yuki Sato <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix
MagicRoundingso that the decision variables can be decoded correctly.Fix #626.
Details and comments
The iteration order of
var2opin the method,_unpack_measurement_outcomein :class:~qiskit_optimization.algorithms.qrao.MagicRoundinghas been modified so that it can correctly run in the order of the decision variables.✅ I have added the tests to cover my changes.
✅ I have updated the documentation accordingly.
✅ I have read the CONTRIBUTING document.