Unpin numpy #629
Merged
Unpin numpy #629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 10259574678Details
💛 - Coveralls |
woodsp-ibm
approved these changes
Aug 6, 2024
There was a problem hiding this comment.
It seems fine to me - given though that the PR which pinned numpy was backported to stable a short while ago #625 did you want to backport this to in effect undo that there too?
|
Yes, let's backport it. |
t-imamichi
added
stable backport potential
mergify bot
pushed a commit
that referenced
this pull request
Aug 7, 2024
* unpin numpy * fix a test * fix style and copyright --------- Co-authored-by: Steve Wood <[email protected]> (cherry picked from commit 65702ea)
mergify bot
added a commit
that referenced
this pull request
Aug 7, 2024
* unpin numpy * fix a test * fix style and copyright --------- Co-authored-by: Steve Wood <[email protected]> (cherry picked from commit 65702ea) Co-authored-by: Takashi Imamichi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
docplex 2.28.240 was released on Aug 2 with numpy 2 support. So, I unpin the numpy version
https://pypi.org/project/docplex/2.28.240/#history
requires #630 to pass CI
Details and comments