Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: generate code & bump to golang 1.21 #316

Merged
merged 6 commits into from
Mar 1, 2024
Merged

chore: generate code & bump to golang 1.21 #316

merged 6 commits into from
Mar 1, 2024

Conversation

glooms
Copy link
Collaborator

@glooms glooms commented Feb 29, 2024

Bumping go-version in go.mod to almost the latest version and updating so the tests run on relevant images.
Could perhaps keep running on golang 1.13 to ensure backwards compatibility, but it shouldn't be a problem.

Fixing the code-generation (broken link to latest-spec) and generate based on latest QIX-rpc spec.

Run go fmt which had been neglected, for whatever reason.

@glooms glooms requested a review from wennmo February 29, 2024 18:18
Copy link
Member

@wennmo wennmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⭐

Copy link
Member

@DnlLrssn DnlLrssn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@glooms glooms merged commit f82ed17 into master Mar 1, 2024
7 checks passed
@glooms glooms deleted the bumps branch March 1, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants