-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an option to not have full depth when no tag matches the expression and config to limit the depth #336
Open
mrozanc
wants to merge
8
commits into
qoomon:master
Choose a base branch
from
mrozanc:feature/distanceOrZero
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Sep 21, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4c1cfe5 - Browse repository at this point
Copy the full SHA 4c1cfe5View commit details
Commits on Sep 22, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e9f82b4 - Browse repository at this point
Copy the full SHA e9f82b4View commit details -
Rename boolean for foundTag and add getter
Marc ROZANC committedSep 22, 2024 Configuration menu - View commit details
-
Copy full SHA for b094b98 - Browse repository at this point
Copy the full SHA b094b98View commit details -
Add describeTagMaxDepth config to limit the repository scan
In case we have a more specific tag pattern to search on a branch, and this pattern does not match any tag in the branch, it's preferable to have a limit to the describe search for performance reasons.
Marc ROZANC committedSep 22, 2024 Configuration menu - View commit details
-
Copy full SHA for b9bd821 - Browse repository at this point
Copy the full SHA b9bd821View commit details -
Fix distance implementation with multiple parents
As the implementation was a counter, when visiting many parents without resetting the counter, the returned distance was not correct. Using the DepthWalk.RevWalk has two benefits: - it can limit the depths - it allows accessing the depth of the current commit instead of trying to do it with custom code
Marc ROZANC committedSep 22, 2024 Configuration menu - View commit details
-
Copy full SHA for 4731084 - Browse repository at this point
Copy the full SHA 4731084View commit details -
- Tags at same depth: no logic implemented to specify which one is selected, so I put one more commit in the test to have different depths. - Version from label=0 plus distance=0 (single commit, no tag), not sure why the test was expecting "1" as a version.
Marc ROZANC committedSep 22, 2024 Configuration menu - View commit details
-
Copy full SHA for 92618f7 - Browse repository at this point
Copy the full SHA 92618f7View commit details
Commits on Oct 4, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 180bcb4 - Browse repository at this point
Copy the full SHA 180bcb4View commit details
Commits on Oct 17, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 51255ce - Browse repository at this point
Copy the full SHA 51255ceView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.