Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1550 Replace node-kind() with new type-of() function #1570

Merged
merged 4 commits into from
Nov 26, 2024
Merged

1550 Replace node-kind() with new type-of() function #1570

merged 4 commits into from
Nov 26, 2024

Conversation

michaelhkay
Copy link
Contributor

Drops the newly-introduced fn:node-kind() function in favour of a more general function fn:type-of().

@michaelhkay
Copy link
Contributor Author

Fix #1550

ChristianGruen
ChristianGruen approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@ChristianGruen ChristianGruen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the proposal. It reads like a good compromise.

@ChristianGruen ChristianGruen added the Tests Needed Tests need to be written or merged label Nov 12, 2024
@line-o
Copy link
Contributor

line-o commented Nov 19, 2024

Thank you, @michaelhkay. This seems like a good compromise.
I would like to see an example with function items added.

@michaelhkay michaelhkay force-pushed the 1550-more-type-information branch from 530b419 to 4a96e0e Compare November 20, 2024 15:23
@ndw
Copy link
Contributor

ndw commented Nov 26, 2024

The CG agreed to merge this PR at meeting 100.

@ndw ndw merged commit aaa2f72 into qt4cg:master Nov 26, 2024
3 checks passed
@michaelhkay michaelhkay added XQFO An issue related to Functions and Operators Enhancement A change or improvement to an existing feature Tests Added Tests have been added to the test suites Completed PR has been applied, tests written and tagged, no further action needed and removed Tests Needed Tests need to be written or merged labels Nov 30, 2024
@michaelhkay michaelhkay mentioned this pull request Dec 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristianGruen ChristianGruen ChristianGruen approved these changes

Assignees
No one assigned
Labels
Completed PR has been applied, tests written and tagged, no further action needed Enhancement A change or improvement to an existing feature Tests Added Tests have been added to the test suites XQFO An issue related to Functions and Operators
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@michaelhkay @line-o @ndw @ChristianGruen