-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1592 Rework rules for selecting a layout #1596
1592 Rework rules for selecting a layout #1596
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@michaelhkay I would need some more time to compare this with the previous approach. Do you think you could easily summarize what has mostly changed, apart from restructuring the layout selection rules?
</olist> | ||
</item> | ||
<item> | ||
<p>If <code>every $e in $EE satisfies all-different($e/*/node-name())</code> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about (https://github.com/qt4cg/qtspecs/issues/1592#issuecomment-2493187896)…
<p>If <code>every $e in $EE satisfies all-different($e/*/node-name())</code> | |
<p>If <code>not(all-equal($EE/*/node-name()))</code> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the replacement expression is correct.
I think it's essentially (a) refactoring the way the layout selection rules are presented (fixing a couple of errors and omissions in the process), (b) adding notes on losslessness. |
In preference to the suggestion for defining a default layout, I have added an option disabled-layouts; for example if |
I’m late, but wouldn't it be nicer to have an inclusive option ( |
I think the likely scenario is that the user will start by choosing the defaults, and if there's something in the output that they don't like, they will either want to provide a specific choice for one particular element, or if it affects a number of elements, they will want to suppress that specific layout. |
0fa582a
to
5386cf9
Compare
The CG agreed to merge this PR at meeting 101. |
I've reworked the rules for selecting a layout. There's probably more to be done, but this is a start - feeback welcome. I'm marking this "revise" for the moment because I haven't finished it yet. There's no deliberate changing of the spec apart from fixing errors.