1659 option conventions sequences as arrays #1664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Drops the rule that options parameters should allow an array if they allow a sequence. We have never applied this rule to any of our functions. Sorry about the GIT noise in creating this pull request. Fix #1659. |
michaelhkay
added
Bug
ChristianGruen
approved these changes
Dec 19, 2024
ChristianGruen
added
the
Propose Merge without Discussion
|
I'm merging this preemptively because the faulty commit and its immediate reversion are causing conflicts for other pull requests. Sorry! |
michaelhkay
added
Completed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.